Skip to content

Commit

Permalink
Improve Maven build and GitHub Maven workflow (#2079)
Browse files Browse the repository at this point in the history
* Fix consecutive Maven builds failing without performing `clean`

By default moditect-maven-plugin refuses to overwrite the JAR file it
generated in a previous run.

* Make GitHub Maven build workflow detect Javadoc issues
  • Loading branch information
Marcono1234 committed Feb 16, 2022
1 parent a0b102c commit d19e9fe
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ jobs:
java-version: '11'
cache: 'maven'
- name: Build with Maven
run: mvn --batch-mode --update-snapshots verify
# This also runs javadoc:javadoc to detect any issues with the Javadoc
run: mvn --batch-mode --update-snapshots verify javadoc:javadoc
2 changes: 2 additions & 0 deletions gson/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@
<module>
<moduleInfoFile>${project.build.sourceDirectory}/module-info.java</moduleInfoFile>
</module>
<!-- Overwrite the previously generated JAR file, if any -->
<overwriteExistingFiles>true</overwriteExistingFiles>
</configuration>
</execution>
</executions>
Expand Down

0 comments on commit d19e9fe

Please sign in to comment.