Remove usage of oss-parent Maven parent and update ReleaseProcess.md
#2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The oss-parent configuration has been applied manually to the root pom.xml, except that now newer plugin versions are used for source and javadoc JAR creation, and for GPG signing. This required some reordering of the plugins for the gson module to make sure they are executed in the correct order. Otherwise this would cause failures for javadoc:jar.
Marcono1234
commented
Jul 26, 2022
Comment on lines
+21
to
+22
| 1. Optional: Create a post on the [Gson Discussion Forum](https://groups.google.com/group/google-gson). | ||
| 1. Optional: Update the release version in [Wikipedia](https://en.wikipedia.org/wiki/Gson) and update the current "stable" release. |
There was a problem hiding this comment.
Have prefixed them with "Optional" because the Google Group does not seem to be that actively used anymore, so updating both of them might not be as important?
Closed
|
Sorry I didn't get to this earlier. Would you mind resolving the conflicts? Then I think we can try this out at the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1605 (even though the bug described there was most likely not casued by oss-parent)
Related: #2149 (comment)
The oss-parent configuration has been applied manually to the root
pom.xml, however there are some differences:Note that the GPG plugin currently does not handle a missing GPG binary very well, throwing a
NullPointerException<releaseProfiles>option of the Maven Release Plugin. This apparently only enables the release profile forrelease:performwhereas the previous approach of using the<arguments>option with-P...seems to have also affectedrelease:prepare. This means that Javadoc or signing issues would not be noticed until afterrelease:perform. Should that be changed?See also
oss-parentPOM here: https://repo1.maven.org/maven2/org/sonatype/oss/oss-parent/9/oss-parent-9.pomThis required some reordering of the plugins for the
gsonmodule to make sure they are executed in the correct order. Otherwise this would cause failures forjavadoc:jarexecuted as part of the release.I have tested this locally a bit by setting the
scminformation and the repository URL to afile:///URI and it seems to work as desired (have not tested GPG). Though would be good if you could nonetheless check if these changes are reasonable.Sonatype also seems to provide their own convenience plugin for publishing to Maven Central, see guide, maybe that would be useful in the future, but I think at the moment it would complicate migrating away from
oss-parenta bit.