Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that GsonBuilder.setExclusionStrategies does not replace existing ones #2168

Conversation

Marcono1234
Copy link
Collaborator

Normally set... methods on builders make it sound like the previously specified value is overwritten, especially when there also exist add... methods. However, this is not the case here so the documentation should explicitly mention this.

Feedback regarding the wording is appreciated.

@eamonnmcmanus
Copy link
Member

That's annoying. Obviously the method should have been called addExclusionStrategies. I guess this isn't important enough to justify deprecating the set... method in favour of a new add... one, but certainly this documentation fix is needed.

@Marcono1234 Marcono1234 force-pushed the marcono1234/GsonBuilder-setExclusionStrategies-doc branch from 306a015 to 6c7d274 Compare August 5, 2022 21:46
@eamonnmcmanus eamonnmcmanus merged commit 390385e into google:master Aug 6, 2022
@Marcono1234 Marcono1234 deleted the marcono1234/GsonBuilder-setExclusionStrategies-doc branch August 7, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants