Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small adjustments to the new record code. #2219

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Small adjustments to the new record code. #2219

merged 2 commits into from
Oct 12, 2022

Conversation

eamonnmcmanus
Copy link
Member

  • Replace wildcard imports with single imports.
  • Enable Java17RecordTest and fix its many previously-hidden problems.
  • Use a Map to get primitive zero values rather than a potentially-expensive reflective trick.
  • Apply some automated code fixes.

@eamonnmcmanus
Small adjustments to the new record code.
70f2bbb 
* Replace wildcard imports with single imports.
* Enable `Java17RecordTest` and fix its many previously-hidden problems.
* Use a `Map` to get primitive zero values rather than a potentially-expensive reflective trick.
* Apply some automated code fixes.
@eamonnmcmanus
Copy link
Member Author

@staale FYI, very minor things.

Marcono1234
Marcono1234 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@Marcono1234 Marcono1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only some minor suggestions for improvements, but if you want I can address them in a separate pull request as well.

gson/src/main/java/com/google/gson/internal/bind/ReflectiveTypeAdapterFactory.java Outdated Show resolved Hide resolved
gson/src/main/java/com/google/gson/internal/bind/ReflectiveTypeAdapterFactory.java Outdated Show resolved Hide resolved
gson/src/test/java/com/google/gson/functional/Java17RecordTest.java Outdated Show resolved Hide resolved
gson/src/test/java/com/google/gson/functional/Java17RecordTest.java Show resolved Hide resolved
gson/src/test/java/com/google/gson/functional/Java17RecordTest.java Outdated Show resolved Hide resolved
@eamonnmcmanus eamonnmcmanus merged commit 86c35bb into google:master Oct 12, 2022
@eamonnmcmanus eamonnmcmanus deleted the recordtweaks branch October 12, 2022 21:24
@Marcono1234 Marcono1234 mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcono1234 Marcono1234 Marcono1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eamonnmcmanus @Marcono1234