Small tweaks to fix Error Prone warnings. #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -277,7 +277,7 @@ | |||
| JsonToken peeked = peek(); | |||
| switch (peeked) { | |||
| case NAME: | |||
| nextName(true); | |||
| String unused = nextName(true); | |||
Check notice
Code scanning / CodeQL
Unread local variable
Marcono1234
reviewed
Oct 25, 2022
| @@ -277,7 +277,7 @@ JsonElement nextJsonElement() throws IOException { | |||
| JsonToken peeked = peek(); | |||
| switch (peeked) { | |||
| case NAME: | |||
| nextName(true); | |||
| String unused = nextName(true); | |||
There was a problem hiding this comment.
Should we add @SuppressWarnings("unused") to avoid (Eclipse) IDE warnings?
There was a problem hiding this comment.
If you send a PR for that, I will merge it. :-)
Error Prone doesn't warn about an unused variable if its name begins with unused.
Eventually I might want to add Error Prone's @CanIgnoreReturnValue to methods like this nextName, and then we wouldn't need to have this assignment. But that would mean introducing a dependency on Error Prone's annotations artifact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.