Remove EOFException special casing of JsonStreamParser.next() #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior violated the Iterator contract where for
`JsonStreamParser("[")` a call to `hasNext()` would return true,
but `next()` would throw a NoSuchElementException.
|
Thanks! I ran this past all of Google's internal tests and didn't find any problems. |
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Jan 20, 2023
…#2281) * Remove EOFException special casing of JsonStreamParser.next() The previous behavior violated the Iterator contract where for `JsonStreamParser("[")` a call to `hasNext()` would return true, but `next()` would throw a NoSuchElementException. * Fix incorrect documented thrown exception type for JsonStreamParser (cherry picked from commit f63a1b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior violated the Iterator contract where for
JsonStreamParser("[")a call tohasNext()would return true, butnext()would throw a NoSuchElementException.I currently cannot think of a use case where such behavior would be desired for incomplete JSON. Maybe that code is just a historic remnant from when
next()did not delegate tohasNext()which itself would run into theEOFException.This should hopefully fix issue #2110 and #2176, though we can also keep them open and (hopefully) let oss-fuzz detect on its own that they are resolved.