Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve variable names in user guide #2290

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

Marcono1234
Copy link
Collaborator

Follow-up for closed pull request #2283

int one = gson.fromJson("1", int.class);
Integer one = gson.fromJson("1", Integer.class);
Long one = gson.fromJson("1", Long.class);
Boolean false = gson.fromJson("false", Boolean.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes, @lengyijun had the right idea here. Imagine calling a variable false!

@eamonnmcmanus eamonnmcmanus merged commit 4aaf138 into google:master Dec 17, 2022
@Marcono1234 Marcono1234 deleted the patch-3 branch December 18, 2022 20:20
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants