Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull request template #2326

Merged

Conversation

Marcono1234
Copy link
Collaborator

@Marcono1234 Marcono1234 commented Feb 26, 2023

Adds a pull request template and slightly extends the README to refer more prominently to the contributing guidelines.

The pull request template is mainly intended as guideline to make sure all necessary information is present and to make sure the code matches (roughly) the expected standard. Not sure if the template is too rigid; feedback (also regarding wording) is appreciated!

@MaicolAntali
Copy link
Contributor

Nice idea!

@eamonnmcmanus
Copy link
Member

LGTM. Thanks!

@eamonnmcmanus eamonnmcmanus merged commit 850e977 into google:master Feb 27, 2023
@Marcono1234 Marcono1234 deleted the marcono1234/pull-request-template branch March 4, 2023 10:55
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants