Bump com.google.errorprone:error_prone_core from 2.21.1 to 2.22.0

[dependabot]

Bumps com.google.errorprone:error_prone_core from 2.21.1 to 2.22.0.

Release notes

Sourced from com.google.errorprone:error_prone_core's releases.

Error Prone 2.22.0

We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass --release 11 to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #3803.

New checks:

• ClosingStandardOutputStreams: Prevents accidentally closing System.{out,err} with try-with-resources
• TruthContainsExactlyElementsInUsage: containsExactly is preferred over containsExactlyElementsIn when creating new iterables
• UnnecessaryAsync: detects unnecessary use of async primitives in local (and hence single-threaded) scopes
• ReturnAtTheEndOfVoidFunction: detects unnecessary return statements at the end of void functions
• MultimapKeys: Suggests using keySet() instead of iterating over Multimap.keys(), which does not collapse duplicates

Bug fixes and improvements:

• Don't complain about literal IP addresses in AddressSelection (google/error-prone@44b6552)
• Prevent SuggestedFixes#renameMethod from modifying return type declaration (#4043)
• Fix UnusedVariable false positives for private record parameters (#2713)
• When running in conservative mode, no longer assume that implementations of Map.get, etc. return null (#2910)
• CanIgnoreReturnValueSuggester: Support additional exempting method annotations (#4009)
• UnusedVariable: exclude junit5's @RegisterExtension (#3892)
• Support running all available patch checks (#947)
• Upgrade java-diff-utils 4.0 -> 4.12 (#4081)
• Flag unused Refaster template parameters (#4060)
• Support @SuppressWarnings("all") (#4065)
• Prevent Refaster UMemberSelect from matching method parameters (#2456)
• MissingDefault : Don't require // fall out comments on expression switches (#2709)
• Skip UnnecessaryLambda findings for usages in enhanced for loops (#2518)
• Fix bug where nested MissingBraces violations' suggested fixes result in broken code (#3797)
• Add support for specifying exemptPrefixes/exemptNames for UnusedVariable via flags (#2753)
• UnusedMethod: Added exempting variable annotations (#2881)

Full Changelog: google/error-prone@v2.21.1...v2.22.0

Commits

• 7114c31 Release Error Prone 2.22.0
• c94d74d Update release.yml - temporarily disable sonatype deployments
• 080411e Added exempting variable annotations
• 737dec0 Remove DiffNotApplicableException
• f3a2bf8 Update ci.yml for JDK 21 release
• 1d2bc93 Introduce ErrorProneFlags.get{Set,List}OrEmpty, because basically every cal...
• 1bec842 Fix a crash in UnnecessaryAsync
• d2ee28e Fix a crash in TimeUnitConversionChecker
• ac424d0 Tighten the return types in Fix.
• 58e5bb8 Update and wordsmith the @CompileTimeConstant documentation to reflect chan...
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[Marcono1234]

Éamonn, in case you edit this PR anyways to fix the build issue; Error Prone version 2.22.0 fixed a false positive for record components (google/error-prone#2713). Could you please remove the following annotations which were needed as workaround? It looks like Error Prone still succeeds afterwards.

gson/graal-native-image-test/src/test/java/com/google/gson/native_test/Java17RecordReflectionTest.java

Line 30 in e93fda9

@SuppressWarnings("UnusedVariable") // workaround for https://github.com/google/error-prone/issues/2713

gson/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java

Lines 75 to 76 in e93fda9

	@SuppressWarnings("unused")
	private record RecordWithCustomNames(

gson/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java

Lines 259 to 260 in e93fda9

	@SuppressWarnings("unused")
	private record RecordWithPrimitives(

gson/gson/src/test/java/com/google/gson/functional/Java17RecordTest.java

Lines 413 to 416 in e93fda9

	@SuppressWarnings("unused")
	private record PrivateRecord(int i) {}
	@SuppressWarnings("unused")
	public record PublicRecord(int i) {}

Or please let me know if I should make those changes.

[eamonnmcmanus]

@dependabot rebase

[eamonnmcmanus]

Éamonn, in case you edit this PR anyways to fix the build issue [...]

I think it's cleanest to have three PRs:

1. Fix the parentheses that provoke the new Error Prone warning;
2. Update the dependency (after asking Dependabot to rebase);
3. Remove the @SuppressWarnings annotations that are no longer needed.

I've just done 1 and 2.

Or please let me know if I should make those changes.

If you don't mind, I would appreciate it.

[Marcono1234]

I think it's cleanest to have three PRs

Personally I think it would have also been quite clean to combine this with the PR updating the Error Prone version, since these changes are directly related to it. Though like this it is fine for me as well.

If you don't mind, I would appreciate it.

Have created #2497