Skip to content

Commit

Permalink
feat!: Support Node 18+ (#896)
Browse files Browse the repository at this point in the history
* feat!: Support Node 18+

Drop Support for older versions of Node.js

* chore: skip windows kitchen sink until #897
  • Loading branch information
danielbankhead authored Oct 10, 2024
1 parent db44cce commit f011fa3
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [14, 16, 18, 20, 21]
node: [18, 20, 22]
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
Expand All @@ -29,7 +29,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 18
- run: npm ci
- run: npm run system-test
system_test:
Expand All @@ -38,7 +38,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 18
- run: npm ci
- run: npm run system-test
lint:
Expand All @@ -47,7 +47,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 18
- run: npm ci
- run: npm run lint
license_check:
Expand All @@ -56,6 +56,6 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 18
- run: npm ci
- run: npm run license-check
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version: 18
registry-url: 'https://wombat-dressing-room.appspot.com'
- run: npm ci
- run: npm publish
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"fix": "eslint --fix '**/*.ts'"
},
"engines": {
"node": ">=14"
"node": ">=18"
},
"keywords": [
"typescript",
Expand Down
4 changes: 3 additions & 1 deletion test/kitchen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ const execOpts = {
encoding: 'utf8' as BufferEncoding,
};

describe('🚰 kitchen sink', () => {
const action = process.platform !== 'win32' ? describe : describe.skip;

action('🚰 kitchen sink', () => {
const fixturesPath = path.join('test', 'fixtures');
const gtsPath = path.join('node_modules', '.bin', 'gts');
const kitchenPath = path.join(stagingPath, 'kitchen');
Expand Down

0 comments on commit f011fa3

Please sign in to comment.