Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clone of https://github.com/google/guava/pull/6730 but with Windows testing on JDK8 #6731

Closed
wants to merge 4 commits into from
Closed

clone of https://github.com/google/guava/pull/6730 but with Windows testing on JDK8 #6731

wants to merge 4 commits into from

Commits on Sep 26, 2023

  1. clone of #6730 but with Windows testing on JDK8 

    Fix `Files.createTempDir` and `FileBackedOutputStream` under Windows _services_, a rare use case.

Fixes #6634

Relevant to #2686 in that it shows that we would ideally run our Windows testing under both Java 8 *and* a newer version....

RELNOTES=`io`: Fixed `Files.createTempDir` and `FileBackedOutputStream` under [Windows _services_, a rare use case](#6634).
PiperOrigin-RevId: 568604081
    @cpovirk
    cpovirk committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    61f135e View commit details
    Browse the repository at this point in the history

  2. Try a more realistic username?

    @cpovirk
    cpovirk committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4692384 View commit details
    Browse the repository at this point in the history

  3. fixed test

    @cpovirk
    cpovirk committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0ed8fae View commit details
    Browse the repository at this point in the history

  4. "merge"

    @cpovirk
    cpovirk committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    bb94109 View commit details
    Browse the repository at this point in the history