Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JpaPersistService.begin() throws exception if a Unit of Work is already opened #972

Closed
jccarrillo opened this issue Dec 29, 2015 · 1 comment · Fixed by #1694
Closed

Comments

@jccarrillo
Copy link
Contributor

The implementation of UnitOfWork.begin() within JpaPersistService does not comply with the definition specified in the javadoc.

"If there is already one open, the invocation will do nothing. In this way, you can define arbitrary units-of-work that nest within one another safely."

The above is not true, the implementation throws an exception if "one" is already opened.

jccarrillo pushed a commit to jccarrillo/guice that referenced this issue Jan 7, 2016
…al implementation which is to throw an exception when an existing session is in progress.
@skuzzle
Copy link

skuzzle commented Jan 11, 2016

Duplicate of #947. Thanks for the fix. I hope it will be accepted.

Edit: Misread it, the PersistServices still faces the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants