Add cmake check for deducing 32bit or 64bit RISCV #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently its only compilable for RV64 when RVV is enabled, this will extend it to build for RV32 with RVV as well
| @@ -59,6 +59,32 @@ if(CHECK_PIE_SUPPORTED) | |||
| endif() | |||
| endif() | |||
|
|
|||
| include(CheckCSourceCompiles) | |||
|
|
|||
| check_c_source_compiles(" | |||
There was a problem hiding this comment.
Thanks, this looks good.
Would you mind making one minor change, wrapping this in something like if (CMAKE_CXX_COMPILER_ARCHITECTURE_ID MATCHES "RISCV32|RISCV64|RISCV128" OR CMAKE_SYSTEM_PROCESSOR MATCHES "riscv32|riscv64|riscv128")) so we do not get extra output on non-RISCV platforms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently its only compilable for RV64 when RVV is enabled, this will extend it to build for RV32 with RVV as well
Upstream-Status: Pending