This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
No more third party directory #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m in via dependencies.
…m some gulp tasks.
This was referenced Dec 22, 2014
| "paper-tabs": "Polymer/paper-tabs#^0.5.2", | ||
| "paper-toast": "Polymer/paper-toast#^0.5.2", | ||
| "polymer": "Polymer/polymer#^0.5.2", | ||
| "requestAnimationFrame": "darius/requestAnimationFrame#master", |
There was a problem hiding this comment.
we should ditch this polyfil. everyone supports raf
| "paper-item": "Polymer/paper-item#^0.5.2", | ||
| "paper-button": "Polymer/paper-button#552f5bbc1796207ebff82171316d639c0d5b7afd", | ||
| "paper-toast": "Polymer/paper-toast#^0.5.2", | ||
| "closure-compiler": "https://dl.google.com/closure-compiler/compiler-latest.zip", |
There was a problem hiding this comment.
Closure compiler doesn't seem to be used in gulpfile, or maybe I'm missing something?
There was a problem hiding this comment.
It's not, but we may in the future. We used it for 🎅 i18n stuff. Among other things. Let's keep it for now.
|
Reviewed |
|
LGTM! if you want one from me :) |
jeffposnick
added a commit
that referenced
this pull request
Dec 23, 2014
No more third party directory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebidel @crhym3 & co:
The overall goal of this PR is to get rid of the
third_partydirectory and pull in all dependencies from their authoritative sources.Some of the dependencies could be pulled in via either
npmorbower, and I went withbower. If we know for some reason that we should prefernpmthen I could switch that around.Since it currently doesn't sound like the
SimpleDBcode is going to be published anywhere else publicly, I moved it fromthird_partytohelper, and cleaned it up to match our JS style. If SimpleDB does get published, or if the author prefers we don't use it, then we'll adjust at that time (tracking bug: #48).The only
bower-installed dependency that we were previously copying over todistwaswebcomponents.min.js. There are a few more things that we need indistnow, I created a new task,copy-bower-dependencies, to handle copying all of them. (The way I listed all of the paths to copy over might not be the most efficient approach.)While I was investigating some of the JS
gulptasks, I also realized that thesw.jsscript wasn't getting copied over todist, so I took care of that.