Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the dependencies group with 2 updates #366

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps the dependencies group with 2 updates: com.google.errorprone:error_prone_core and org.apache.maven.plugins:maven-gpg-plugin.

Updates com.google.errorprone:error_prone_core from 2.31.0 to 2.32.0

Release notes

Sourced from com.google.errorprone:error_prone_core's releases.

Error Prone 2.32.0

The minimum support JDK version to run Error Prone is now JDK 17 (#3803).

Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will requires using JDK 17 or newer for compilation and setting --release or -source/-target/-bootclasspath.

Full changelog: google/error-prone@v2.31.0...v2.32.0

Commits
  • 0fe0961 Release Error Prone 2.32.0
  • 655bdc4 Update release.yml: remove JDK 11
  • a9ff9b1 Update ci.yml: remove JDK 11
  • 4e0b19c Start using Java > 11 language features in Error Prone tests
  • 4b5ee1e Update ci.yml: always set up JDK 17
  • 494e2c6 Don't perform the inlining if parameter names are stripped.
  • dab4089 Add the name of the method to the diagnostic message for MemberName.
  • 671ac41 Update ci.yml to use javadoc:javadoc
  • See full diff in compare view

Updates org.apache.maven.plugins:maven-gpg-plugin from 3.2.5 to 3.2.6

Release notes

Sourced from org.apache.maven.plugins:maven-gpg-plugin's releases.

3.2.6

Release Notes - Maven GPG Plugin - Version 3.2.6


What's Changed

New Contributors

Full Changelog: apache/maven-gpg-plugin@maven-gpg-plugin-3.2.5...maven-gpg-plugin-3.2.6

Commits
  • 1c9a14c [maven-release-plugin] prepare release maven-gpg-plugin-3.2.6
  • bbe6156 Add FAQ for "no pinentry" issue (#118)
  • 5b94273 [MGPG-141] Remove use of deprecated classes (#117)
  • afdfd28 [MGPG-138] Drop direct use of plexus-cipher and secdispatcher (#115)
  • 7516e7c [MGPG-140] Update Maven to 3.9.9 (#116)
  • 4ec571f [MGPG-139] Bump org.apache.maven.plugins:maven-invoker-plugin from 3.7.0 to 3...
  • 1126b7b use new Reproducible Central badge endpoint
  • 1b40a05 [MGPG-135] Support Overriding / Enhance the signer in AbstractGpgMojo (#112)
  • 3a31714 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 16, 2024
@cpovirk
Copy link
Member

cpovirk commented Sep 16, 2024

Since Error Prone dropped support for javac versions below 17, we'll need to either stop using Error Prone (which would probably actually be fine, since we still run it internally, including the @Beta checking that has become much less necessary now that few APIs are still @Beta) or else switch to always using newer versions of javac when targeting older versions (which is a good idea anyway), as in google/guava#7333 (though it wouldn't be as hard to set up here).

@dependabot dependabot bot force-pushed the dependabot/maven/dependencies-caa0bd8aea branch from 2d94a92 to 5c7ee8c Compare September 23, 2024 05:05
Bumps the dependencies group with 2 updates: [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) and [org.apache.maven.plugins:maven-gpg-plugin](https://github.com/apache/maven-gpg-plugin).


Updates `com.google.errorprone:error_prone_core` from 2.31.0 to 2.32.0
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.31.0...v2.32.0)

Updates `org.apache.maven.plugins:maven-gpg-plugin` from 3.2.5 to 3.2.6
- [Release notes](https://github.com/apache/maven-gpg-plugin/releases)
- [Commits](apache/maven-gpg-plugin@maven-gpg-plugin-3.2.5...maven-gpg-plugin-3.2.6)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: dependencies
- dependency-name: org.apache.maven.plugins:maven-gpg-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/dependencies-caa0bd8aea branch from 5c7ee8c to c06ce7f Compare September 23, 2024 21:04
@chaoren
Copy link
Member

chaoren commented Sep 24, 2024

Do we just need to update .github/workflows/ci.yml here?

@chaoren chaoren self-assigned this Sep 24, 2024
@cpovirk
Copy link
Member

cpovirk commented Sep 24, 2024

I think we want to continue testing jimfs under a JDK 11 runtime, so we can't just remove our job for JDK 11. Instead, we'll need to modify our Maven setup to build with a newer javac while still testing with 11. (Or we can drop Error Prone from our Maven setup.)

@chaoren chaoren added the P2 label Sep 24, 2024
@chaoren
Copy link
Member

chaoren commented Sep 24, 2024

Could we just disable the error prone run on certain JDKs?

@cpovirk
Copy link
Member

cpovirk commented Sep 24, 2024

Ah, good point. That should also work.

@chaoren
Copy link
Member

chaoren commented Sep 24, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 24, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Sep 24, 2024
@dependabot dependabot bot deleted the dependabot/maven/dependencies-caa0bd8aea branch September 24, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants