Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has been reviewed and submitted internally. Feel free to discuss on the PR and we can submit follow-up changes as necessary.
Commits:
Travis: use 'openjdk8' instead of 'oraclejdk8'
(This now restores coverage for 8, and I made a similar change for 11.)
Fixes #89
d30e344
maven-compiler-plugin 3.8.1
Fixes #90
54912ec
Run Error Prone as a plugin.
If run in the old style, it uses javac9, which can't handle the Java 11 class files in the JDK11 bootclasspath.
This follows the instructions at https://errorprone.info/docs/installation#maven
Note also the need to include -Xep:BetaApi:OFF in the same arg as -Xplugin:ErrorProne: google/error-prone#1136 (comment) google/error-prone#1115
(Also, incidentally update Error Prone itself. I forget whether I had a Java-11-related reason for that, but it seems like a good idea.)
7e467aa
Prepare Javadoc for Java 11, and make other improvements:
It does look like it may be necessary to duplicate all the links in 3 places :
This is all in service of preventing:
[ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/9/docs/api/ are in the unnamed module.
Traditionally we solve this problem by setting
7b2eccd