Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement objectRemoveKey #1070

Merged
merged 1 commit into from
May 25, 2023

Conversation

rohitjangid
Copy link
Member

Implemented std.objectRemoveKey method to remove a key from a object

PR for go-jsonnet: google/go-jsonnet#686

@@ -1497,6 +1497,20 @@ local html = import 'html.libsonnet';
},
],
},
{
name: 'Objets',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objects

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really most of the functions from "types and reflection" should go in here as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the typo. I checked all the functions from "types and reflection" and moved them to this section whichever made sense to me.

@rohitjangid rohitjangid force-pushed the feat/object-remove-key branch from 35e5f88 to 86de93e Compare May 4, 2023 03:57
@sparkprime sparkprime merged commit 72a74d8 into google:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants