-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 support CronJobs #16
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks for the contribution @oeduardoal, this looks great! You'll need to sign the CLA before I can merge. |
Thank you @halvards! I just needed to fix the code to pass on tests. |
Thanks @oeduardoal! Could you please add a unit test for You can see how to programmatically create K8s resources in |
I believe this PR also needs to add code to pick up |
@halvards tests added!! |
Thanks for adding the tests @oeduardoal! @breunigs is right though, this change also needs to handle registry authentication by picking up |
@oeduardoal Thanks for the PR. We are facing this limitation and we'd like to know if there is any update to add this feature. Thanks again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution - and your patience!
Solve: #15
This PR allows k8s-digester to work with CronJob in Kubernetes