This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Storage Factory #1558
Merged
Storage Factory #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
+ Coverage 69.27% 69.39% +0.11%
==========================================
Files 58 58
Lines 4355 4355
==========================================
+ Hits 3017 3022 +5
+ Misses 906 899 -7
- Partials 432 434 +2
Continue to review full report at Codecov.
|
mhutchinson
reviewed
Jun 5, 2020
Comment on lines
+38
to
+50
| Logs interface { | ||
| sequencer.LogsReader | ||
|
|
||
| // Copied methods from adminserver.LogsAdmin because of duplicate method. | ||
|
|
||
| // AddLogs creates and adds new logs for writing to a directory. | ||
| AddLogs(ctx context.Context, directoryID string, logIDs ...int64) error | ||
| // SetWritable enables or disables new writes from going to logID. | ||
| SetWritable(ctx context.Context, directoryID string, logID int64, enabled bool) error | ||
|
|
||
| // Copied methods from keyserver.MutationLogs | ||
| SendBatch(ctx context.Context, directoryID string, logID int64, batch []*pb.EntryUpdate) (water.Mark, error) | ||
| } |
There was a problem hiding this comment.
Can you get a Go Native to review this? It looks a bit clunky to me.
There was a problem hiding this comment.
This is a bit of a known issue: golang/go#6977
https://golang.org/ref/spec#Uniqueness_of_identifiers
I think these could be merged if the interfaces were in the same package, because they are in different packages, they are different identifiers.
mhutchinson
approved these changes
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support creating storage implementations of various types.