This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Implement fetching and verifying SEHs from CT #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update appender to save SignedCertificateTimestamps to facilitate hash computation - Create CT helper utility for testing - Update client to fetch inclusion proof via GetProofByHash Depends on google/certificate-transparency#1249 Full inclusion proof verification depends on google/certificate-transparency#1159
| @@ -24,8 +24,10 @@ type Appender interface { | |||
| Append(ctx context.Context, epoch int64, data []byte) error | |||
|
|
|||
| // Epoch retrieves a specific object. | |||
| Epoch(ctx context.Context, epoch int64) ([]byte, error) | |||
| // Returns data and a serialized ct.SignedCertificateTimestamp | |||
| Epoch(ctx context.Context, epoch int64) ([]byte, []byte, error) | |||
There was a problem hiding this comment.
It's your choice but returning multiple byte arrays is going to be a confusing API when you read it again in 3 months.
|
I've done a pass over it. Looks basically OK, with some suggestions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computation
Depends on [Go] Implement GetProofByHash certificate-transparency#1249
Full inclusion proof verification depends on
google/certificate-transparency#1159