Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Allow istio sidecar injection for all broker components #1736

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

yolocs
Copy link
Member

@yolocs yolocs commented Sep 17, 2020

Fixes #1732

Proposed Changes

  • Allows istio sidecar injection for all broker components

Release Note

Allows istio sidecar injection for all broker components

Docs

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Sep 17, 2020
Copy link
Contributor

@danyinggu danyinggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-wi-tests 2020-09-17 21:34:08.637 +0000 UTC
2020-09-17 22:16:38.382 +0000 UTC
2/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-wi-tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow the controller to inject istio sidecar proxy.
4 participants