This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Use consistent informer and lister for dependency tracking #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ectelion The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-cla
bot
added
the
cla: yes
zhongduo
reviewed
Nov 2, 2020
| func (t testHelper) ReadyDependencyStatus() *duckv1.KResource { | ||
| kr := &duckv1.KResource{} | ||
| func (t testHelper) ReadyDependencyStatus() *duckv1.Source { | ||
| kr := &duckv1.Source{} |
There was a problem hiding this comment.
nit: we can replace all kr in this file with like src.
There was a problem hiding this comment.
Makes sense, have addressed that.
| @@ -141,7 +141,7 @@ func (ts *TriggerStatus) MarkDependencyNotConfigured() { | |||
| "DependencyNotConfigured", "Dependency has not yet been reconciled.") | |||
| } | |||
|
|
|||
| func (ts *TriggerStatus) PropagateDependencyStatus(ks *duckv1.KResource) { | |||
| func (ts *TriggerStatus) PropagateDependencyStatus(ks *duckv1.Source) { | |||
There was a problem hiding this comment.
same here, replace ks and kc to something more related to Source.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1835
Proposed Changes
Refer to knative/eventing#4296 for a relevant change. Same informer/lister construct for tracking dependencies was inherited by the trigger reconciler in the GCP repo.