Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

backport release-0.19: Check if spec.retry is nil before dereferencing it. (#2052) #2145

Merged

Conversation

tommyreddad
Copy link
Contributor

Fixes #2051

Proposed Changes

  • Check if spec.retry is nil before dereferencing it.

Release Note

- 🐛 Fixed a potential nil pointer dereference when using a GCP Broker.

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Feb 12, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tommyreddad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/trigger/trigger.go 58.0% 67.6% 9.6

@nlopezgi nlopezgi requested a review from zhongduo February 12, 2021 20:42
@tommyreddad
Copy link
Contributor Author

/retest

@zhongduo
Copy link
Contributor

/lgtm

@zhongduo
Copy link
Contributor

/hold
This issue is already fixed by the latest master code, can you make sure the logic are the same?

@tommyreddad
Copy link
Contributor Author

I cherry-picked the commit, it is the same logic. You can check the original to see it is the same: #2052

@zhongduo
Copy link
Contributor

/unhold

@zhongduo
Copy link
Contributor

/retest

2 similar comments
@tommyreddad
Copy link
Contributor Author

/retest

@tommyreddad
Copy link
Contributor Author

/retest

@zhongduo
Copy link
Contributor

/lgtm

@zhongduo
Copy link
Contributor

/retest

@tommyreddad
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit 5a19bc2 into google:release-0.19 Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants