Fix -Wunused-function warning in db_bench.cc #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning was recently enabled more widely in Chromium, and it fired on this
file:
../../third_party/leveldatabase/src/db/db_bench.cc(145,14):
error: unused function 'TrimSpace' [-Werror,-Wunused-function]
static Slice TrimSpace(Slice s) {
^
cmumford
added a commit
that referenced
this pull request
Oct 13, 2015
Incorporated change by zmodem at #310 to fix issue #310. This change will only build TrimSace on linux to avoid unused function warning/error. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=105323419
cmumford
added a commit
that referenced
this pull request
Dec 9, 2015
Incorporated change by zmodem at #310 to fix issue #310. This change will only build TrimSace on linux to avoid unused function warning/error. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=105323419
|
Incorporated manually in 3c9ff3c before we were setup to accept pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was recently enabled more widely in Chromium, and it fired on this
file:
../../third_party/leveldatabase/src/db/db_bench.cc(145,14):
error: unused function 'TrimSpace' [-Werror,-Wunused-function]
static Slice TrimSpace(Slice s) {
^