Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added google/benchmark submodule. #853

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Conversation

cmumford
Copy link
Contributor

Recent changes (ed78107 and 99ab473) introduced the use of the google/benchmark library. This change adds the necessary Git submodule and cmake changes to successfully build.

@google-cla google-cla bot added the cla: yes label Nov 30, 2020
@pwnall pwnall self-assigned this Nov 30, 2020
@pwnall
Copy link
Member

pwnall commented Nov 30, 2020

Thank you very much for this! I'll review in the internal repository.

As a reminder for both of us, after this gets published to GitHub, we'll need to merge a PR that fixes git attributes directly in GitHub.

Examples from when we did this dance with googletest:

@cmumford
Copy link
Contributor Author

cmumford commented Nov 30, 2020 via email

@cmumford cmumford merged commit 28df521 into google:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants