Use setJavadoc instead of accumulating.

google · Sep 26, 2024 · bbce4a4 · bbce4a4
1 parent ab9e6b9
commit bbce4a4
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java b/tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java
@@ -378,7 +378,7 @@ private static void writeRegionCodeConstantsToJavaFile(Collection<String> region
         .setModifiers("final")
         .setCopyright(Integer.parseInt(copyright));
 
-    writer.addToJavadoc(REGION_CODE_CONSTS_JAVADOC);
+    writer.setJavadoc(REGION_CODE_CONSTS_JAVADOC);
 
     for (String regionCode : regionCodeList) {
       String variableName = regionCode.toUpperCase();
@@ -423,13 +423,7 @@ final Builder addToImports(String name) {
         return this;
       }
 
-      abstract Builder setJavadoc(String javadoc);
-      private final StringBuilder javadocBuilder = new StringBuilder();
-      final Builder addToJavadoc(String text) {
-        javadocBuilder.append(text);
-        return this;
-      }
-
+      abstract Builder setJavadoc(String javadoc);      
       abstract Builder setName(String name);
       abstract Builder setModifiers(String modifiers);
 
@@ -448,7 +442,6 @@ final Builder formatToBody(String format, Object... args) {
       abstract ClassWriter autoBuild();
 
       final ClassWriter build() {
-        setJavadoc(javadocBuilder.toString());
         setBody(bodyBuilder.toString());
         return autoBuild();
       }