-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Drawer and Header Pop #1656
Comments
The drawer is being moved out of the frame later by a @addyosmani @sgomes Should we add a style hiding the drawer element until |
@surma Yup, that's sort of the solution I've already coded :) |
Go @sgomes! 👏 |
addyosmani
added a commit
that referenced
this issue
Sep 28, 2015
Fixes fixed drawer initial positioning. Fixes #1656
Is this ok to get into 1.0.5? |
Yes, it's already merged into the |
Closing this as #1657 has landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, the initial CSS pushes the header to the right by adding a margin to account for the nav drawer.
This is removed by JS once it kicks in, but this causes a pop on load.
Originally reported on Web Fundamentals.
google/WebFundamentals#1869
The text was updated successfully, but these errors were encountered: