Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Drawer and Header Pop #1656

Closed
gauntface opened this issue Sep 28, 2015 · 6 comments
Closed

Navigation Drawer and Header Pop #1656

gauntface opened this issue Sep 28, 2015 · 6 comments
Assignees
Milestone

Comments

@gauntface
Copy link

At the moment, the initial CSS pushes the header to the right by adding a margin to account for the nav drawer.

This is removed by JS once it kicks in, but this causes a pop on load.

Originally reported on Web Fundamentals.
google/WebFundamentals#1869

@surma
Copy link
Contributor

surma commented Sep 28, 2015

The drawer is being moved out of the frame later by a transform.

@addyosmani @sgomes Should we add a style hiding the drawer element until is-upgraded is added?

@surma surma added this to the V1.1 milestone Sep 28, 2015
@sgomes
Copy link
Contributor

sgomes commented Sep 28, 2015

@surma Yup, that's sort of the solution I've already coded :)

@surma
Copy link
Contributor

surma commented Sep 28, 2015

Go @sgomes! 👏

sgomes pushed a commit that referenced this issue Sep 28, 2015
addyosmani added a commit that referenced this issue Sep 28, 2015
Fixes fixed drawer initial positioning. Fixes #1656
@gauntface
Copy link
Author

Is this ok to get into 1.0.5?

@sgomes
Copy link
Contributor

sgomes commented Sep 28, 2015

Yes, it's already merged into the mdl-1.0 branch and will make it to 1.0.5.

@surma
Copy link
Contributor

surma commented Sep 28, 2015

Closing this as #1657 has landed.

@surma surma closed this as completed Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants