Closure fixes #1551
Merged
Closure fixes #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. No BC concerns either, looks like anything that may cause problems isn't supported usage in the first place (since mods are to internal properties.) |
|
LGTM. Deferring to @samthor for a final LGTM before we move ahead. |
| /** | ||
| * Function to publish staging or prod version from local tree, | ||
| * or to promote staging to prod, per passed arg. | ||
| * @param {string} pubScope the scope to publish to. |
There was a problem hiding this comment.
nit: single space between @param and {string}
There was a problem hiding this comment.
Silly docblockr. Thanks!
|
LGTM modulo nits. Do you want to get #1547 in too? |
|
Thanks for the review, @samthor! I'll add those changes in, squash and commit. I'll review #1547 for you after this, but it's probably best to keep them separate for now. I suspect we'll need yet another PR to fix some things up after they're both merged (we're probably missing some exports/externs). |
Also configures JSCS to work with our code a bit better. Adding license and description to closure-camel-case.js Some extra fixes Fixes from @samthor review
sgomes
force-pushed
the
closure-fixes
branch
from
d88bedf to
fde7a98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the codebase to play better with the Closure compiler and JSDoc.
It also tweaks the JSCS config, updates the JSCS version and adds a custom linting rule, all in to enforce checks a bit better.
This PR shouldn't break BC.
@addyosmani @samthor PTAL!