-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More closure fixes #1570
More closure fixes #1570
Conversation
This includes global symbol exporting and improved typing.
LGTM. I don't see why any supported levels of interaction would break. |
LGTM2 👍 mdlComponentHandler is ridiculous, though ^^ |
@surma Yup. It's more documentation than code, at this point... |
1f19446
to
26ea680
Compare
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
26ea680
to
1f19446
Compare
CLAs look good, thanks! |
@surma 🎶 Don't go breaking my branch... 🎤 Ahem. I don't think it's a problem to keep the |
btw, I'm glad this works, but it's clear each export becomes frustratingly verbose. We can probably export everything by default (which is fine, since everything's in self-evaluating etc etc) or use |
I'm happy to look more at this within the next ~24 hours (timezones are hard). |
@sgomes Yeah, of course. Go ahead :) |
@samthor I don't think there's a good way to export everything by default, other than using externs. In any case, I'll merge this as-is for now, and we can treat improvements as a new PR, so that we can do further development on Closure gulp tasks and the like in the meantime. |
This PR contains more fixes to help with Closure compiler support, adding fixes necessary to have it not only compile, but run correctly as well. This includes exporting symbols (using the
foo['bar']
syntax), ensuring private properties aren't accessed by outsiders and typing things a bit more strongly in the componentHandler.All unit tests pass on both compiled and uncompiled code.
@addyosmani @surma PTAL!