Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated imp module with importlib #24

Closed
hugovk opened this issue Apr 29, 2023 · 1 comment · May be fixed by #28
Closed

Replace deprecated imp module with importlib #24

hugovk opened this issue Apr 29, 2023 · 1 comment · May be fixed by #28
Labels
bug Something isn't working

Comments

@hugovk
Copy link

hugovk commented Apr 29, 2023

Describe the bug

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

To Reproduce

git grep "\bimp\b"

Expected behavior
A clear and concise description of what you expected to happen.

Works on Python 3.12 using importlib.
@hugovk hugovk added the bug Something isn't working label Apr 29, 2023
@hugovk hugovk mentioned this issue May 3, 2023
Open
31 tasks
@danielkelshaw
Copy link

Also get this error -- would be great if it could be fixed!

@danielkelshaw danielkelshaw mentioned this issue Feb 6, 2024
Open
@hylkedonker hylkedonker mentioned this issue May 28, 2024
Closed
marcenacp added a commit to marcenacp/ml_collections that referenced this issue Jun 11, 2024
@marcenacp
Replace the usage of deprecated imp module in order to work with Py…
76029a3 
…thon 3.12.

Fixes: google#24.
PiperOrigin-RevId: 641152140
Change-Id: Ide2d88b5fdbe804617495df129176c3692033d45
marcenacp added a commit to marcenacp/ml_collections that referenced this issue Jun 11, 2024
@marcenacp
Replace the usage of deprecated imp module in order to work with Py…
2fc3f86 
…thon 3.12.

Fixes: google#24.
PiperOrigin-RevId: 641152140
Change-Id: Ide2d88b5fdbe804617495df129176c3692033d45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update import machinery for Python 3.12 compatibility danielkelshaw/ml_collections
2 participants
@hugovk @danielkelshaw