Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove skip test mathopt highs #4418

Merged
merged 1 commit into from
Oct 22, 2024
Merged

remove skip test mathopt highs #4418

merged 1 commit into from
Oct 22, 2024

Conversation

galabovaa
Copy link

@galabovaa galabovaa commented Oct 21, 2024

@galabovaa
Copy link
Author

@lperron

@Mizux
Copy link
Collaborator

Mizux commented Oct 21, 2024

Should we also remove this ?

if (GetParam().solver_type == SolverType::kHighs) {
GTEST_SKIP() << "Ignoring this test as Highs 1.7+ returns MODEL_INVALID";
}

@galabovaa
Copy link
Author

I will double check that it passes for me locally!

@galabovaa
Copy link
Author

I get a failure if I comment out

if (GetParam().solver_type == SolverType::kHighs) {
GTEST_SKIP() << "Ignoring this test as Highs 1.7+ returns MODEL_INVALID";
}

I will need to look into it further, so let's leave it for the next PR.

@Mizux Mizux self-assigned this Oct 22, 2024
@Mizux Mizux added Feature Request Missing Feature/Wrapper Solver: HiGHS Issue specific to EDU HiGHS labels Oct 22, 2024
@Mizux Mizux added this to the v9.12 milestone Oct 22, 2024
@Mizux Mizux merged commit bba6bbb into google:main Oct 22, 2024
72 of 158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Missing Feature/Wrapper Solver: HiGHS Issue specific to EDU HiGHS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants