prompt_builder: add list of header files in code fixing prompt #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun exp -n dk1007 |
DonggeLiu
reviewed
Jun 12, 2024
| with open(HEADER_FIXER_PROMPT, 'r') as f: | ||
| header_avoid_string = f.read() | ||
| for header_file in headers_to_avoid: | ||
| header_avoid_string += '- %s\n' % (os.path.basename(header_file)) |
| @@ -297,6 +299,17 @@ def _format_fixer_problem(self, raw_code: str, error_desc: Optional[str], | |||
| else: | |||
| # Build error does not pass error desc. | |||
| error_summary = BUILD_ERROR_SUMMARY | |||
| headers_to_avoid = introspector.query_introspector_header_files( | |||
| benchmark.project) | |||
| if len(headers_to_avoid) > 0: | |||
There was a problem hiding this comment.
nit: if headers_to_avoid: for simplicity
| @@ -83,6 +85,7 @@ def set_introspector_endpoints(endpoint): | |||
| INTROSPECTOR_FUNC_SIG = f'{INTROSPECTOR_ENDPOINT}/function-signature' | |||
| INTROSPECTOR_ADDR_TYPE = ( | |||
| f'{INTROSPECTOR_ENDPOINT}/addr-to-recursive-dwarf-info') | |||
| INTROSPECTOR_ALL_HEADER_FILES = (f'{INTROSPECTOR_ENDPOINT}/all-header-files') | |||
There was a problem hiding this comment.
no need for () if this fits into one line.
| @@ -46,6 +46,7 @@ | |||
| 'jansi_colors-problem.txt') | |||
| FDP_JVM_EXAMPLE_2_SOLUTION = os.path.join(EXAMPLE_PATH, | |||
| 'jansi_colors-solution.java') | |||
| HEADER_FIXER_PROMPT = os.path.join(DEFAULT_TEMPLATE_DIR, 'header_fixer.txt') | |||
There was a problem hiding this comment.
Did you add this file yet?
|
I'll put this on hold for a few days @DonggeLiu as I think it can be improved but it takes a bit of experimentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.