Attempted fix for urllib3 crashes #10022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've still got an issue with crashes on the urllib3 requests test that uses the mock HTTP server.
Fix #9958 to handle port mapping errors didn't resolve it.
I got a feeling there's an ordering issue. Looking at the error logs https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=56500#c2 there appears to be an issue where we're throwing exceptions before the coverage completes.
This is an attempted fix inspired by the requests fuzz_server.py where the lifecycle of the test thread is managed within the server. Since the web server is created at the start of
TestOneInput
I don't expect there to be any timing issues or thread initialisation issues.