Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

askama: initial integration #10935

Merged
merged 7 commits into from
Sep 14, 2023
Merged

askama: initial integration #10935

merged 7 commits into from
Sep 14, 2023

Conversation

manunio
Copy link
Contributor

@manunio manunio commented Sep 11, 2023 •
edited
Loading

Hi, Askama is one of the popular template rendering engine based on Jinja.

  • It has 3 million+ downloads as per crates.io.
  • It being used by projects like:

@github-actions
Copy link

manunio is integrating a new project:
- Main repo: https://github.com/djc/askama
- Criticality score: 0.58955

@manunio manunio mentioned this pull request Sep 11, 2023
Merged
@djc
Copy link
Contributor

djc commented Sep 13, 2023 •
edited
Loading

  • Plotly.js
    • Plotly.js is a standalone Javascript data visualization library, and it also powers the Python and R modules named plotly in those respective ecosystems (referred to as Plotly.py and Plotly.R).

Where are you getting this? The plotly.js repo doesn't contain any Rust code, so I'm confused about how it might be using Askama.

@manunio
Copy link
Contributor Author

manunio commented Sep 13, 2023

  • Plotly.js

    • Plotly.js is a standalone Javascript data visualization library, and it also powers the Python and R modules named plotly in those respective ecosystems (referred to as Plotly.py and Plotly.R).

Where are you getting this? The plotly.js repo doesn't contain any Rust code, so I'm confused about how it might be using Askama.

It looks like i messed up in here, plotly.rs is using plotly.js which uses askama, not the other way around. Sorry about that, I'll update the description.

@manunio manunio changed the title [wip] askama: initial integration askama: initial integration Sep 13, 2023
@manunio manunio marked this pull request as ready for review September 13, 2023 14:12
@DonggeLiu
Copy link
Contributor

Thanks, @manunio!
I guess this is not ready for review yet : )
Let me convert this to a draft, but please always feel free to convert it back once ready.

@DonggeLiu DonggeLiu marked this pull request as draft September 14, 2023 01:25
@manunio
Copy link
Contributor Author

manunio commented Sep 14, 2023 •
edited
Loading

Hi @alan32liu it's ready for review. I have striked out/removed wrong info from description of this pr.

cc @djc

@manunio manunio marked this pull request as ready for review September 14, 2023 02:29
@DonggeLiu
Copy link
Contributor

Hi @alan32liu it's ready for review. I have striked out/removed wrong info from description of this pr.

cc @djc

OK, I will ask the panel.

@DonggeLiu
Copy link
Contributor

Panel approved, let's merge it if it looks good to @djc .

@manunio
Copy link
Contributor Author

manunio commented Sep 14, 2023

Panel approved, let's merge it if it looks good to @djc .

Hi @alan32liu , I have received permission from djc, please check below comment.
https://github.com/djc/askama/issues/860#issuecomment-1713559265

@DonggeLiu DonggeLiu merged commit ee9f211 into google:master Sep 14, 2023
15 checks passed
@manunio manunio deleted the askama branch September 14, 2023 12:42
@manunio manunio mentioned this pull request Sep 22, 2023
Closed
gedigi pushed a commit to gedigi/oss-fuzz that referenced this pull request Sep 27, 2023
@manunio @gedigi
askama: initial integration (google#10935)
adb38ca 
Hi, [Askama](https://github.com/djc/askama) is one of the popular
template rendering engine based on
[Jinja](https://jinja.palletsprojects.com/).
- It has `3 million+` downloads as per
[crates.io](https://crates.io/crates/askama).
 - It being used by projects like:
   - [mozilla/uniffi-rs](https://github.com/mozilla/uniffi-rs)
     - a multi-language bindings generator for rust. 
- It also used along with web frameworks like
[actix](https://crates.io/crates/actix),
[axum](https://crates.io/crates/axum),
[warp](https://crates.io/crates/warp).
@Kijewski Kijewski mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonggeLiu DonggeLiu DonggeLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manunio @djc @DonggeLiu