Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rules_fuzzing presubmit #11675

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Fix rules_fuzzing presubmit #11675

merged 2 commits into from
Mar 7, 2024

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Mar 6, 2024

Copy link

github-actions bot commented Mar 6, 2024

fmeum has previously contributed to projects/bazel-rules-fuzzing-test-java. The previous PR was #9024
fmeum has previously contributed to projects/bazel-rules-fuzzing-test. The previous PR was #9024

@fmeum fmeum marked this pull request as ready for review March 6, 2024 23:30
@fmeum
Copy link
Contributor Author

fmeum commented Mar 6, 2024

FYI @stefanbucur

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this should should be propagated into the bazel builder script as well?

declare -r BAZEL_BUILD_FLAGS=(
"-c" "opt"
"--@rules_fuzzing//fuzzing:cc_engine=@rules_fuzzing_oss_fuzz//:oss_fuzz_engine" \
"--@rules_fuzzing//fuzzing:java_engine=@rules_fuzzing_oss_fuzz//:oss_fuzz_java_engine" \
"--@rules_fuzzing//fuzzing:cc_engine_instrumentation=oss-fuzz" \
"--@rules_fuzzing//fuzzing:cc_engine_sanitizer=none" \
"--cxxopt=-stdlib=libc++" \
"--linkopt=-lc++" \
"--verbose_failures" \
"--spawn_strategy=standalone" \
"--action_env=CC=${CC}" "--action_env=CXX=${CXX}" \
${BAZEL_EXTRA_BUILD_FLAGS[*]}
)

@fmeum
Copy link
Contributor Author

fmeum commented Mar 7, 2024

@DavidKorczynski It shouldn't: Standalone builds are (slightly) faster and thus are better for large, real projects. The incompatibility is only with --features=layering_check, which rules_fuzzing specifies for itself to ensure that it is also compatible with end user projects using that feature - this isn't relevant for those.

@DavidKorczynski
Copy link
Collaborator

@DavidKorczynski It shouldn't: Standalone builds are (slightly) faster and thus are better for large, real projects. The incompatibility is only with --features=layering_check, which rules_fuzzing specifies for itself to ensure that it is also compatible with end user projects using that feature - this isn't relevant for those.

Thanks!

@DavidKorczynski DavidKorczynski merged commit c0c4b54 into google:master Mar 7, 2024
15 checks passed
@fmeum fmeum deleted the patch-14 branch March 7, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants