-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rules_fuzzing presubmit #11675
Fix rules_fuzzing presubmit #11675
Conversation
fmeum has previously contributed to projects/bazel-rules-fuzzing-test-java. The previous PR was #9024 |
FYI @stefanbucur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if this should should be propagated into the bazel builder script as well?
oss-fuzz/infra/base-images/base-builder/bazel_build_fuzz_tests
Lines 50 to 62 in 9d03475
declare -r BAZEL_BUILD_FLAGS=( | |
"-c" "opt" | |
"--@rules_fuzzing//fuzzing:cc_engine=@rules_fuzzing_oss_fuzz//:oss_fuzz_engine" \ | |
"--@rules_fuzzing//fuzzing:java_engine=@rules_fuzzing_oss_fuzz//:oss_fuzz_java_engine" \ | |
"--@rules_fuzzing//fuzzing:cc_engine_instrumentation=oss-fuzz" \ | |
"--@rules_fuzzing//fuzzing:cc_engine_sanitizer=none" \ | |
"--cxxopt=-stdlib=libc++" \ | |
"--linkopt=-lc++" \ | |
"--verbose_failures" \ | |
"--spawn_strategy=standalone" \ | |
"--action_env=CC=${CC}" "--action_env=CXX=${CXX}" \ | |
${BAZEL_EXTRA_BUILD_FLAGS[*]} | |
) |
@DavidKorczynski It shouldn't: Standalone builds are (slightly) faster and thus are better for large, real projects. The incompatibility is only with |
Thanks! |
Work around bazelbuild/bazel#21592 as discovered in bazel-contrib/rules_fuzzing#242 (comment).