Do not call HTMLParser.unescape() in Python 3.9 in six #12540
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably, #11419 will be resolved at some point in the future by upgrading the base image to Python > 3.8. Maybe by #11420, maybe by #12027, maybe by a PR that has yet to be created.
When that happens, 'six' will have a problem.
oss-fuzz/projects/six/fuzz_six.py
Lines 58 to 59 in 7fa4a40
In Python 3.9, 'unescape' was removed from HTMLParser - https://docs.python.org/3/whatsnew/3.9.html#porting-to-python-3-9
Looking at the 'six' source code,
unescape
isn't actually called by anything internally. HTMLParser is sure, but that's it. So if the method is gone in Python >= 3.9, then there's no need to continue testing it when Python is upgraded.