Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang 18.1 remove rust pins #12555

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

catenacyber
Copy link
Contributor

A draft following #12365 and plan to cherry-pick e0d6875

now that base-builder-rust uses a more modern one
Copy link

github-actions bot commented Oct 2, 2024

catenacyber is a new contributor to projects/libressl. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, guidovranken, joshuasing, gilles-peskine-arm, DonggeLiu, botovq, Navidem, devtty1er, Dor1s, busterb (unverified), inferno-chromium
catenacyber is a new contributor to projects/rustcrypto. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, DonggeLiu, guidovranken
catenacyber is a new contributor to projects/orbit. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, joycebrum, beckerhe, ronaldfw, antonrohr
catenacyber is a new contributor to projects/solidity. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, bshastry, DonggeLiu, Dor1s
catenacyber is a new contributor to projects/boost. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, TheZ3ro, DonggeLiu, Navidem, inferno-chromium, Dor1s, bshastry (unverified), pauldreik (unverified), kcc, nevir (unverified)
catenacyber is a new contributor to projects/tensorflow-serving. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko
catenacyber is a new contributor to projects/xnu. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, nedwill
catenacyber is a new contributor to projects/immer. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, alex-sparus, pinotree, DonggeLiu, arximboldi
catenacyber is a new contributor to projects/ampproject. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko
catenacyber is a new contributor to projects/cryptofuzz. The PR must be approved by known contributors before it can be merged. The past contributors are: guidovranken, moz-mdauer, maflcko, justindhillon, gilles-peskine-arm, skrah, DonggeLiu
catenacyber is a new contributor to projects/libecc. The PR must be approved by known contributors before it can be merged. The past contributors are: guidovranken, maflcko, DonggeLiu, Navidem
catenacyber is a new contributor to projects/quiche. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko
catenacyber has previously contributed to projects/tensorflow. The previous PR was #6860
catenacyber is either the primary contact or is in the CCs list of projects/libhtp.
catenacyber has previously contributed to projects/libhtp. The previous PR was #12217
catenacyber is a new contributor to projects/zeek. The PR must be approved by known contributors before it can be merged. The past contributors are: awelzel, maflcko, timwoj, inferno-chromium, jsiwek, devtty1er
catenacyber is a new contributor to projects/bignum-fuzzer. The PR must be approved by known contributors before it can be merged. The past contributors are: gilles-peskine-arm, maflcko, skrah, guidovranken, daverodgman, inferno-chromium, danh-arm, devtty1er, Dor1s, yanesca (unverified)
catenacyber is a new contributor to projects/nettle. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, guidovranken, gilles-peskine-arm, DonggeLiu, Navidem, ueno
catenacyber is a new contributor to projects/opencv. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, mshabunin, DonggeLiu, Navidem, autofuzzoss, vrabaud, Dor1s, alalek (unverified), markus-kusano (unverified)
catenacyber is a new contributor to projects/pcl. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, DonggeLiu, mvieth, kunaltyagi
catenacyber is a new contributor to projects/boost-json. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, grisumbras, DonggeLiu, pauldreik

@catenacyber
Copy link
Contributor Author

cc @maflcko we will see with CI which projects fail for unpinning

@maflcko
Copy link
Contributor

maflcko commented Oct 2, 2024

All projects that need modifications should still be failing, for example quiche, see #12094. Also, CI may not be able to compile all of them in the limited time, so it may be better to unpin them in "batches" or one-by-one? But up to you. Either way seems fine, if it works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file, and all files that have OLD_LLVMPASS set: I think you can remove it as well, if the unpin really works, but I haven't tried it myself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to remove all the lines like projects/bearssl/Dockerfile:ENV OLD_LLVMPASS 1 ?

I can try that.
But let me first get a green CI ;-)

@catenacyber
Copy link
Contributor Author

All projects that need modifications should still be failing, for example quiche, see #12094.

Indeed

Also, CI may not be able to compile all of them in the limited time, so it may be better to unpin them in "batches" or one-by-one? But up to you. Either way seems fine, if it works.

There are 20 projects, I hope CI can handle it

now that clang was updated ton 18.1 and nightly is more recent
@catenacyber catenacyber changed the title Clang 18.1 remove old pins Clang 18.1 remove rust pins Oct 2, 2024
@DavidKorczynski DavidKorczynski merged commit 1e451bf into google:master Oct 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants