Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove usage of OLD_LLVMPASS #12561

Merged
merged 3 commits into from
Oct 9, 2024
Merged

remove usage of OLD_LLVMPASS #12561

merged 3 commits into from
Oct 9, 2024

Conversation

catenacyber
Copy link
Contributor

Following #12365
cc @maflcko

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

catenacyber is a new contributor to projects/bearssl. The PR must be approved by known contributors before it can be merged. The past contributors are: guidovranken, maflcko, DonggeLiu, Navidem
catenacyber is a new contributor to projects/perfetto. The PR must be approved by known contributors before it can be merged. The past contributors are: DonggeLiu, adamgoogz, Navidem, ddiproietto, bcreasey, fmayer, devtty1er, Dor1s, inferno-chromium
catenacyber is a new contributor to projects/bls-signatures. The PR must be approved by known contributors before it can be merged. The past contributors are: guidovranken, maflcko, DonggeLiu, Navidem
catenacyber is a new contributor to projects/cmake. The PR must be approved by known contributors before it can be merged. The past contributors are: DonggeLiu, Navidem
catenacyber is either the primary contact or is in the CCs list of projects/cel-cpp.
catenacyber has previously contributed to projects/cel-cpp. The previous PR was #5326
catenacyber is either the primary contact or is in the CCs list of projects/dart.
catenacyber has previously contributed to projects/dart. The previous PR was #5568
catenacyber is a new contributor to projects/wolfssl. The PR must be approved by known contributors before it can be merged. The past contributors are: JacobBarthelmeh, guidovranken, maflcko, ejohnstown, philljj, Uriah-wolfSSL, tim-weller-wolfssl, Navidem
catenacyber is a new contributor to projects/firestore. The PR must be approved by known contributors before it can be merged. The past contributors are: DonggeLiu, Navidem, devtty1er, inferno-chromium, Dor1s, var-const (unverified)
catenacyber is a new contributor to projects/libecc. The PR must be approved by known contributors before it can be merged. The past contributors are: guidovranken, maflcko, DonggeLiu, Navidem
catenacyber is a new contributor to projects/json. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, DonggeLiu, Navidem, nlohmann, inferno-chromium, devtty1er, tanuj208, Dor1s, ssbr (unverified), vitalybuka (unverified), mikea (unverified)
catenacyber is a new contributor to projects/nettle. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, guidovranken, gilles-peskine-arm, DonggeLiu, Navidem, ueno
catenacyber is a new contributor to projects/oatpp. The PR must be approved by known contributors before it can be merged. The past contributors are: DonggeLiu, Navidem
catenacyber is a new contributor to projects/opencv. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, mshabunin, DonggeLiu, Navidem, autofuzzoss, vrabaud, Dor1s, alalek (unverified), markus-kusano (unverified)
catenacyber is a new contributor to projects/cyclonedds. The PR must be approved by known contributors before it can be merged. The past contributors are: Navidem, phretor
catenacyber is a new contributor to projects/git. The PR must be approved by known contributors before it can be merged. The past contributors are: steadmon, briantracy, JarLob, illia-v, arthurscchan, Navidem, ahunt
catenacyber is either the primary contact or is in the CCs list of projects/gnupg.
catenacyber has previously contributed to projects/gnupg. The previous PR was #6316
catenacyber is a new contributor to projects/flatbuffers. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, DonggeLiu, Navidem, inferno-chromium, vglavnyy
catenacyber is a new contributor to projects/relic. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, guidovranken, DonggeLiu, Navidem

maflcko
maflcko reviewed Oct 7, 2024
View reviewed changes
projects/bearssl/Dockerfile Outdated
@@ -24,4 +24,3 @@ RUN wget https://archives.boost.io/release/1.84.0/source/boost_1_84_0.tar.bz2
COPY build.sh $SRC/
# This is to fix Fuzz Introspector build by using LLVM old pass manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to remove the comment as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in fixup commit :-)

@oliverchang
Copy link
Collaborator

thanks!

@oliverchang
Copy link
Collaborator

/gcbrun trial_build.py all --fuzzing-engines libfuzzer --sanitizers introspector

@catenacyber
Copy link
Contributor Author

What is gcbrun result ?

DavidKorczynski
DavidKorczynski approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the flag is used no more and no longer exists, so whether the build succeed or not this should be good.

@DavidKorczynski DavidKorczynski merged commit aebe4a9 into google:master Oct 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maflcko maflcko maflcko left review comments

@DavidKorczynski DavidKorczynski DavidKorczynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catenacyber @oliverchang @DavidKorczynski @maflcko