Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trial-builds] Speed up first trial build by using real image as cache #9535

Merged
merged 6 commits into from
Feb 7, 2023
Merged

[trial-builds] Speed up first trial build by using real image as cache #9535

merged 6 commits into from
Feb 7, 2023

Conversation

jonathanmetzman
Copy link
Contributor

No description provided.

@jonathanmetzman
Copy link
Contributor Author

/gcbrun trial_build.py wasmtime skcms --sanitizer coverage address --fuzzing-engine libfuzzer

@jonathanmetzman
Copy link
Contributor Author

I don't think this actually resulted in a speed up.

@jonathanmetzman
Copy link
Contributor Author

I think one reason the cache get invalidated a lot is when ubuntu:20.04 gets updated. Maybe we should pin it? @oliverchang ?

@oliverchang
Copy link
Collaborator

I think one reason the cache get invalidated a lot is when ubuntu:20.04 gets updated. Maybe we should pin it? @oliverchang ?

Yeah let's pin.

@jonathanmetzman
Copy link
Contributor Author

/gcbrun trial_build.py wasmtime skcms --sanitizer coverage address --fuzzing-engine libfuzzer

@jonathanmetzman
Copy link
Contributor Author

/gcbrun trial_build.py wasmtime skcms --sanitizer coverage address --fuzzing-engine libfuzzer

@jonathanmetzman
Try speeding up trial builds
f51b102 
Use regular base-images as cache as well to speed up first build.
@jonathanmetzman
tmp
c46ccd9
@jonathanmetzman
fix
2823783
@jonathanmetzman
fmt
231e221
@jonathanmetzman
fix
d1076d4
@jonathanmetzman
Copy link
Contributor Author

/gcbrun trial_build.py wasmtime skcms --sanitizer coverage address --fuzzing-engine libfuzzer

@jonathanmetzman
Copy link
Contributor Author

/gcbrun trial_build.py wasmtime skcms --sanitizer coverage address --fuzzing-engine libfuzzer

@jonathanmetzman
Copy link
Contributor Author

/gcbrun trial_build.py wasmtime skcms --sanitizer coverage address --fuzzing-engine libfuzzer

@jonathanmetzman jonathanmetzman changed the title Speed up first trial build by using real image as cache [trial-builds] Speed up first trial build by using real image as cache Feb 6, 2023
@jonathanmetzman jonathanmetzman merged commit daef594 into master Feb 7, 2023
@jonathanmetzman jonathanmetzman deleted the try-speed-tb branch February 7, 2023 00:36
DonggeLiu
DonggeLiu reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eamonnmcmanus pushed a commit to eamonnmcmanus/oss-fuzz that referenced this pull request Mar 15, 2023
@jonathanmetzman @eamonnmcmanus
[trial-builds] Speed up first trial build by using real image as cache (
8ce6f8b 
google#9535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonggeLiu DonggeLiu DonggeLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanmetzman @oliverchang @DonggeLiu