Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize position management #67

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Externalize position management #67

merged 2 commits into from
Feb 9, 2024

Conversation

hchataing
Copy link
Collaborator

@hchataing hchataing commented Feb 9, 2024

Refactor library to remove dependency on Position

The position of devices was previously managed by the Pica
context instance and updated by pica commands such as
SetPosition/InitUciDevice.

This change introduces the RangingEstimator trait, and adds
an instance of ranging estimator to the parameters of the
Pica::new() function.

Instead of relying on device positions, ranging measurements
are now produced by the owned instance of RangingEstimator.

The http server _which receives HTTP requests to update
device positions_ now caches the device positions instead of the
Pica context, and implements a RangingEstimator to pass
to the Pica context.

@hchataing hchataing changed the title position Externalize position management Feb 9, 2024
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
tests/test_runner.py Show resolved Hide resolved
The position of devices was previously managed by the Pica
context instance and updated by pica commands such as
SetPosition/InitUciDevice.

This change introduces the RangingEstimator trait, and adds
an instance of ranging estimator to the parameters of the
Pica::new() function.

Instead of relying on device positions, ranging measurements
are now produced by the owned instance of RangingEstimator.

The http server _which receives HTTP requests to update
device positions_ now caches the device positions instead of the
Pica context, and implements a RangingEstimator to pass
to the Pica context.
@hchataing hchataing merged commit 99f6638 into main Feb 9, 2024
6 checks passed
@hchataing hchataing deleted the position branch February 13, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants