Return status 33 when ranging is not available between devices. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not send ShortMacTwoWaySessionInfoNtf with no measurement back to host. Instead, send measurement with status 33 when ranging is not available.
|
Could you add a small test to validate the change please ? You can copy the ranging_example and modify it for that. |
hchataing
reviewed
Jun 21, 2024
| } | ||
| } | ||
| // If a controlee drops out due to out of range or power off etc, send | ||
| // ranging measurement with status 33. |
There was a problem hiding this comment.
with code STATUS_RANGING_RX_TIMEOUT
| @@ -438,7 +458,7 @@ impl Pica { | |||
| continue; | |||
| } | |||
|
|
|||
| if peer_device.can_start_ranging(session, session_id) { | |||
| if peer_device.is_compatible_for_ranging(session, session_id) { | |||
There was a problem hiding this comment.
I think you check the wrong condition here: you should be checking if the session app_config contains the peer_device, but you check if the peer_device has a session that contains the session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not send ShortMacTwoWaySessionInfoNtf with no measurement back
to host. Instead, send measurement with status 33 when ranging is not
available.