Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nodejs tested versions to active releases (14, 16, 18, 19) #229

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Oct 21, 2022

Had to upgrade nan to the latest version which has the fix for nodejs/nan#942. Related to #170 but still no pre-built binaries for node18+.

@aabmass aabmass requested a review from punya October 22, 2022 17:09
@aabmass aabmass marked this pull request as ready for review October 22, 2022 17:10
@aabmass aabmass force-pushed the fix-node-versions branch 2 times, most recently from 5ee8cb3 to 4a171b1 Compare October 22, 2022 19:56
Copy link
Collaborator

@punya punya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽

@aabmass aabmass merged commit 08d7eff into google:main Oct 24, 2022
@aabmass aabmass deleted the fix-node-versions branch October 24, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants