-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panics if profile is not found #863
Comments
aalexand
added a commit
to aalexand/pprof
that referenced
this issue
May 23, 2024
odeke-em
added a commit
to orijtech/pprof
that referenced
this issue
May 24, 2024
This change inverts checks to ensure that we return a wrapped fs.ErrNotExist error if we completely fail to find a source fetcher, instead of panicking. Fixes google#863
Sorry I introduced this unexpected error. |
aalexand
added a commit
that referenced
this issue
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! I opened golang/go#67626 for the Go project to track consuming a fix; my guess is there should be an issue on this project to track creation of a fix.
What version of pprof are you using?
I've checked out 9665fa2 from May 20, currently the latest version of the
main
branch.What operating system and processor architecture are you using?
linux/amd64
What did you do?
What did you expect to see?
What did you see instead?
Bisect says " a5a03c7 is the first bad commit".
CC @cuishuang, @aalexand
The text was updated successfully, but these errors were encountered: