Use go:embed for thirdparty #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quasilyte
approved these changes
Sep 1, 2023
aalexand
reviewed
Sep 1, 2023
cristaloleg
force-pushed
the
use-go-embed
branch
from
80137c5
to
c4380af
Compare
aalexand
approved these changes
Sep 1, 2023
|
Will merge once CI passes. |
Codecov Report
@@ Coverage Diff @@
## main #801 +/- ##
=======================================
Coverage 66.99% 66.99%
=======================================
Files 45 45
Lines 9861 9861
=======================================
Hits 6606 6606
Misses 2795 2795
Partials 460 460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies handing of 3rd party files.
npm installalso changedpackage-lock.jsonpretty heavily, not sure should I commit this too or not. WDYT ?