Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share unit definitions between Go and Javascript. #852

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

ghemawat
Copy link
Contributor

Go unit definitions (from measurement package) are now converted to JSON and delivered to Javascript code so that we do not need to duplicate these definitions in Javascript.

Had to make the unit type definitions exported with public fields.

Also had to change a test case to expect "us" instead of "µs".

Go unit definitions (from measurement package) are now converted to
JSON and delivered to Javascript code so that we do not need to
duplicate these definitions in Javascript.

Had to make the unit type definitions exported with public fields.

Also had to change a test case to expect "us" instead of "µs".
@ghemawat ghemawat requested a review from aalexand April 24, 2024 21:31
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.92%. Comparing base (0ed6a68) to head (0b38b77).
Report is 14 commits behind head on main.

Files Patch % Lines
internal/measurement/measurement.go 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   66.86%   66.92%   +0.05%     
==========================================
  Files          44       44              
  Lines        9824     9792      -32     
==========================================
- Hits         6569     6553      -16     
+ Misses       2794     2784      -10     
+ Partials      461      455       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aalexand aalexand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aalexand aalexand merged commit a892ee0 into google:main Apr 24, 2024
31 checks passed
@ghemawat ghemawat deleted the commonunits branch April 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants