Update runner to Go 1.22,1.23 (two most recent releases). #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexand
previously approved these changes
Aug 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
+ Coverage 66.86% 67.00% +0.13%
==========================================
Files 44 44
Lines 9824 9798 -26
==========================================
- Hits 6569 6565 -4
+ Misses 2794 2780 -14
+ Partials 461 453 -8 ☔ View full report in Codecov by Sentry. |
v1.51 fails with errors related to old slices package.
aalexand
previously approved these changes
Aug 27, 2024
| with: | ||
| # Bootstrapping go tip requires 1.22.6 | ||
| go-version: 1.22 | ||
| cache: true |
There was a problem hiding this comment.
Why are these cache manipulation needed?
May worth a comment.
There was a problem hiding this comment.
Without these we get errors from setup-go about it not being able to use the cache. (I think it might be related to having multiple go.sum files in our repo). I will add a comment.
|
This PR should now be mergeable. |
aalexand
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.