Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle dsl to specify the mainClass for protocPlugin #455

Open
mahieddine opened this issue Dec 18, 2020 · 6 comments
Open

Gradle dsl to specify the mainClass for protocPlugin #455

mahieddine opened this issue Dec 18, 2020 · 6 comments

Comments

@mahieddine
Copy link

mahieddine commented Dec 18, 2020

Hi,

I'm trying to rewrite this maven build script into gradle and i'm stuck with this section :

<protocPlugins>
        <protocPlugin>
            <id>quarkus-grpc-protoc-plugin</id>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-grpc-protoc-plugin</artifactId>
            <version>1.10.5.Final</version>
            <mainClass>io.quarkus.grpc.protoc.plugin.MutinyGrpcGenerator</mainClass>
        </protocPlugin>
</protocPlugins>

How can we specify the mainClass for pure java plugins ?

@voidzcy
Copy link
Collaborator

voidzcy commented Dec 28, 2020

Unfortunately, it only supports uber jar plugins now 😢 and requires the plugin jar specifies the main class in its manifest. We will probably add a mainClass API as that for the maven plugin, but we cannot foresee when that will happen.

/cc @Scottmitch

@mahieddine
Copy link
Author

Thank you for the confirmation, yeah it would be awesome if we can do that, the only temporary workaround that i found for the moment is to download the plugin jar, set the main class into the manifest and use that local version and it indeed work perfectly.

@ethan-gallant
Copy link

I just wanted to touch base on this issue. Are PRs welcome to implement this feature? Or is it on the roadmap?

@voidzcy
Copy link
Collaborator

voidzcy commented Jul 14, 2021

I just wanted to touch base on this issue. Are PRs welcome to implement this feature? Or is it on the roadmap?

Sure, PRs are welcome.

@EarthChen
Copy link

EarthChen commented Jul 17, 2021

I have same problem . hope this feature will be completed soon。now i use maven gen code with idl file,and coding in gradle project..

@ejona86
Copy link
Collaborator

ejona86 commented Nov 8, 2023

For quarkus, it looks like the quarkus project should just set main-class in their generated JAR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants