Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle compatiblity #1

Closed
jtjeferreira opened this issue Feb 8, 2022 · 1 comment · Fixed by #2
Closed

Gradle compatiblity #1

jtjeferreira opened this issue Feb 8, 2022 · 1 comment · Fixed by #2

Comments

@jtjeferreira
Copy link
Contributor

Hi!

I wanted to try your plugin in my project but I am using gradle. I think due to this issue that is not possible.
While that ticket is not solved the only workaround is to declare the mainclass in the manifest and publish a new version...

I will try to do this locally first to see if it works, and later try to do a PR (if my skills allow it)
jtjeferreira added a commit to jtjeferreira/protoc-gen-java-optional that referenced this issue Feb 8, 2022
@jtjeferreira
Update mainClass
ce285a7 
Fixes Fadelis#1
@jtjeferreira jtjeferreira mentioned this issue Feb 8, 2022
Merged
@Fadelis Fadelis closed this as completed in #2 Feb 8, 2022
@Fadelis
Copy link
Owner

Fadelis commented Feb 8, 2022

Haven't tested it with gradle, but it worked with maven even with that typo. Thanks for the contribution, should be available with 1.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update mainClass jtjeferreira/protoc-gen-java-optional
2 participants
@jtjeferreira @Fadelis