Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plural form default output directory 'generated/sources' #754

Closed
holgerstolzenberg opened this issue May 2, 2024 · 2 comments · Fixed by #755
Closed

Use plural form default output directory 'generated/sources' #754

holgerstolzenberg opened this issue May 2, 2024 · 2 comments · Fixed by #755

Comments

@holgerstolzenberg
Copy link
Contributor

holgerstolzenberg commented May 2, 2024

Currently the plugin per default generates the generated java code into "$project/$buildDir/generated/source".
This kinda breaks Gradle best practices, please see screenshot below:

Screenshot 2024-05-02 at 21 49 26

As you can see, all other stuff in the build directory uses a plural based syntax. Even the protobuf plugin does that e.g. for "extracted-protoS" and so on. Also for that manner the generated code is not aggregated with the other generated sources in their respective sourceSets under "generated/sourceS".

Please align the plugins output to the best practices.

Optionally:
What is the reasoning behind not having the configurable?

ejona86 pushed a commit that referenced this issue Nov 13, 2024
Use generated/sources/proto (plural) instead source.

Fixes #754
@holgerstolzenberg
Copy link
Contributor Author

Any chance we can get that released? Do you have a rough roadmap for the next release?

@NurramoX
Copy link

+1
I would also appreciate having this change released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants