-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TravisCI support #78
Comments
This issue is not actually CI-specific. |
@zhangkun83 Yeah. There has just gotta be a better way. Normal maven/gradle projects do not require you to install the snapshot locally. Normally the examples would use the "release". I am guessing you have the examples use the "latest snapshot" for CI integration testing. |
@zhangkun83 Either way, I can help you add TravisCI support, we can run |
That would be great. TravisCI is indeed useful, though installing Android SDK on Travis may be tricky. |
Android is actually not too bad on TravisCI. The only reason we don't do it with grpc is because it is incompatible with also testing on osx (and the emulator is slow, but that wouldn't impact this project). |
@zhangkun83 The SDK is easy to install on Travis. Please see: https://github.com/jaredsburrows/android-gradle-java-app-template @ejona86 I see needs osx: https://github.com/grpc/grpc/blob/master/.travis.yml. But for this plugin, which is written in |
@jaredsburrows, I agree there's no need for OS X on this project. @zhangkun83 is familiar with grpc-java and I was mentioning why it is hard specifically for that project, but shouldn't be difficult for this one. |
@zhangkun83 @ejona86 Sounds good. I'll make a PR as soon as TravisCI is turned on for this project. |
@zhangkun83, I can't enable Travis for this project. I think can do it at https://travis-ci.org/profile/google |
I just did it: https://travis-ci.org/google/protobuf-gradle-plugin |
@zhangkun83 Thank you. All test projects run except the |
No, I never tried to do it. First I needed to run under JDK 7 to avoid the "bad class file magic (cafebabe) or version (0034.0000)" error. After that I got the "Duplicate files copied in APK io/grpc/testing/integration/messages.proto". |
@zhangkun83 Yeah. Adding:
to
to I am still looking into it. |
@zhangkun83 Now I am seeing:
|
You can use |
@ejona86 |
@jaredsburrows, yeah, to exclude/pickfirst the dup'ed .proto files (they aren't used anyway). It looks like they are duped because testProject has a copy of the .proto to test normal proto vs nano proto. |
@ejona86 Thanks.
This did not:
|
@zhangkun83 @ejona86 Thanks. I have solved the problem and the build passes. |
Closing this because code was merged: #79. |
Add TravisCI support
Right after cloning the project, simply running
gradlew tasks
fails:Adding CI will fix these issues.
The text was updated successfully, but these errors were encountered: